Re: Improve checks for GUC recovery_target_xid

From: Hüseyin Demir <huseyin(dot)d3r(at)gmail(dot)com>
To: David Steele <david(at)pgbackrest(dot)org>
Cc: Fujii Masao <masao(dot)fujii(at)gmail(dot)com>, Michael Paquier <michael(at)paquier(dot)xyz>, Pg Hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Improve checks for GUC recovery_target_xid
Date: 2026-03-16 07:44:44
Message-ID: CAB5wL7Y=BK7jf7J_shotdBqE9cVy4wgZhk1QuFdoeGonDQwaZg@mail.gmail.com
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Hi,

David Steele <david(at)pgbackrest(dot)org>, 6 Mar 2026 Cum, 16:01 tarihinde şunu yazdı:
>
> On 3/6/26 14:05, Fujii Masao wrote:
> > On Fri, Mar 6, 2026 at 3:15 PM Michael Paquier <michael(at)paquier(dot)xyz> wrote:
> >>
> >> On Fri, Mar 06, 2026 at 12:04:00AM +0900, Fujii Masao wrote:
> >>> Thanks for the patch! It looks good to me. Barring any objections, I
> >>> will commit it.
> >>
> >> Thanks.
> >
> > I've pushed the patch. Thanks!
>
> Thank you and great idea on ALTER SYSTEM. I've been hesitant to add more
> tests in this area because they are so expensive but now I feel much
> better about it. But that's the last for this CF since there is more
> important stuff to be done.
>
> Regards,
> -David

I tried to create tests with the ALTER SYSTEM approach to validate the GUC.

You can review it if it's the correct approach or not. We can create a
new CF record if required for the patch.

Regards.

Attachment Content-Type Size
v1-0001-add-regression-tests-for-recovery-target-xid-validation.patch application/octet-stream 2.1 KB

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Dmitrii Bondar 2026-03-16 07:45:41 Re: Pgbench: remove synchronous prepare
Previous Message Chao Li 2026-03-16 07:33:10 Re: [oauth] Stabilize the libpq-oauth ABI (and allow alternative implementations?)