| From: | Joseph Koshakow <koshy44(at)gmail(dot)com> |
|---|---|
| To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
| Cc: | Ashutosh Bapat <ashutosh(dot)bapat(dot)oss(at)gmail(dot)com>, "Gregory Stark (as CFM)" <stark(dot)cfm(at)gmail(dot)com>, jian he <jian(dot)universality(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: Infinite Interval |
| Date: | 2023-03-19 21:46:02 |
| Message-ID: | CAAvxfHfgkcSwTPF-u+uqRo70hxFGTm3tf6+OgtYWEV_MiyKnYw@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Sun, Mar 19, 2023 at 5:13 PM Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
>
> Did you actually write "if TIMESTAMP_IS_NOBEGIN(dt2)" and not
> "if (TIMESTAMP_IS_NOBEGIN(dt2))"? If the former, I'm not surprised
> that pgindent gets confused. The parentheses are required by the
> C standard. Your code might accidentally work because the macro
> has parentheses internally, but call sites have no business
> knowing that. For example, it would be completely legit to change
> TIMESTAMP_IS_NOBEGIN to be a plain function, and then this would be
> syntactically incorrect.
Oh duh. I've been doing too much Rust development and did this without
thinking. I've attached a patch with a fix.
- Joe Koshakow
| Attachment | Content-Type | Size |
|---|---|---|
| v16-0003-Add-infinite-interval-values.patch | text/x-patch | 90.2 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Michael Paquier | 2023-03-19 22:06:22 | Re: Fix fseek() detection of unseekable files on WIN32 |
| Previous Message | Tom Lane | 2023-03-19 21:13:01 | Re: Infinite Interval |