| From: | Joseph Koshakow <koshy44(at)gmail(dot)com> |
|---|---|
| To: | jian he <jian(dot)universality(at)gmail(dot)com> |
| Cc: | Ashutosh Bapat <ashutosh(dot)bapat(dot)oss(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: Infinite Interval |
| Date: | 2023-01-07 22:52:16 |
| Message-ID: | CAAvxfHfRO+wRHr1pT2CUoZ685dCd0uyxK9higNoPvUHin6rL0g@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Sat, Jan 7, 2023 at 3:05 PM Joseph Koshakow <koshy44(at)gmail(dot)com> wrote:
>
> On Sat, Jan 7, 2023 at 3:04 PM Joseph Koshakow <koshy44(at)gmail(dot)com> wrote:
> >
> > I think this patch is just about ready for review, except for the
> > following two questions:
> > 1. Should finite checks on intervals only look at months or all three
> > fields?
> > 2. Should we make the error messages for adding/subtracting infinite
> > values more generic or leave them as is?
> >
> > My opinions are
> > 1. We should only look at months.
> > 2. We should make the errors more generic.
> >
> > Anyone else have any thoughts?
Here's a patch with the more generic error messages.
- Joe
| Attachment | Content-Type | Size |
|---|---|---|
| v10-0001-Support-infinite-interval.patch | text/x-patch | 61.1 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Andres Freund | 2023-01-07 22:55:48 | Re: Using WaitEventSet in the postmaster |
| Previous Message | David Rowley | 2023-01-07 22:36:58 | Re: Todo: Teach planner to evaluate multiple windows in the optimal order |