| From: | Joseph Koshakow <koshy44(at)gmail(dot)com> |
|---|---|
| To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
| Cc: | Keisuke Kuroda <kuroda(dot)keisuke(at)nttcom(dot)co(dot)jp>, pgsql-hackers(at)lists(dot)postgresql(dot)org |
| Subject: | Re: Date-time extraneous fields with reserved keywords |
| Date: | 2023-03-04 20:05:08 |
| Message-ID: | CAAvxfHeZA43KTJZ7=-dpJR1MQkZXzXqozizqLFLh7t6Xya3swA@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Sat, Mar 4, 2023 at 2:48 PM Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
>
> Right. So really we ought to move the ValidateDate call as
> well as the next half-dozen lines about "mer" down into
> the subsequent "do additional checking" stanza. It's all
> only relevant to normal date specs.
>
> BTW, looking at the set of RESERV tokens in datetktbl[],
> it looks to me like this change renders the final "default:"
> case unreachable, so probably we could just make that an error.
Please see the attached patch with these changes.
- Joe Koshakow
| Attachment | Content-Type | Size |
|---|---|---|
| v3-0001-Handle-extraneous-fields-in-date-time-input.patch | text/x-patch | 10.9 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tom Lane | 2023-03-04 21:05:33 | Re: Date-Time dangling unit fix |
| Previous Message | Thomas Munro | 2023-03-04 19:50:30 | Re: Latches vs lwlock contention |