Re: DecodeInterval fixes

From: Joseph Koshakow <koshy44(at)gmail(dot)com>
To: Gurjeet Singh <gurjeet(at)singh(dot)im>
Cc: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Jacob Champion <jchampion(at)timescale(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: DecodeInterval fixes
Date: 2023-07-09 17:24:13
Message-ID: CAAvxfHeR561xCFmB-o3Qx-uGhNp+2jriOVDBagNU-GzikzZsBw@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Sat, Jul 8, 2023 at 5:06 PM Gurjeet Singh <gurjeet(at)singh(dot)im> wrote:

> I feel the staleness/deficiencies you mention above are not
> captured in the TODO wiki page. It'd be nice if these were documented,
> so that newcomers to the community can pick up work that they feel is
> an easy lift for them.

I think that's a good idea. I've definitely been confused by this in
previous patches I've submitted.

I've broken up this patch into three logical commits and attached them.
None of the actual code has changed.

Thanks,
Joe Koshakow

Attachment Content-Type Size
v3-0001-Remove-dead-code-in-DecodeInterval.patch text/x-patch 1.0 KB
v3-0002-Fix-Interval-ago-parsing.patch text/x-patch 2.4 KB
v3-0003-Fix-Interval-unit-parsing.patch text/x-patch 3.6 KB

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Heikki Linnakangas 2023-07-09 18:05:53 Re: BRIN indexes vs. SK_SEARCHARRAY (and preprocessing scan keys)
Previous Message Joseph Koshakow 2023-07-09 17:03:14 Re: Preventing non-superusers from altering session authorization