| From: | Joseph Koshakow <koshy44(at)gmail(dot)com> |
|---|---|
| To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
| Cc: | PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: Fix overflow hazard in interval rounding |
| Date: | 2024-02-13 20:28:08 |
| Message-ID: | CAAvxfHdL5BVqN2mmNvfxgcxu27KDfiHbjpXd9QhZhsyTuhGaZA@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Tue, Feb 13, 2024 at 1:46 PM Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
> I think you need to use ereturn not ereport here; see other error
> cases in AdjustIntervalForTypmod.
Attached is an updated patch that makes this adjustment.
> (We'd need ereport in back branches, but this problem seems to
> me to probably not be worth back-patching.)
Agreed, this seems like a pretty rare overflow/underflow.
Thanks,
Joe Koshakow
| Attachment | Content-Type | Size |
|---|---|---|
| v2-0001-Fix-overflow-hazard-in-interval-rounding.patch | text/x-patch | 3.4 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tom Lane | 2024-02-13 21:01:19 | Re: Fix overflow hazard in interval rounding |
| Previous Message | vignesh C | 2024-02-13 20:20:08 | Re: pg_upgrade and logical replication |