Re: jit and explain nontext

From: David Rowley <dgrowleyml(at)gmail(dot)com>
To: Justin Pryzby <pryzby(at)telsasoft(dot)com>
Cc: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>, Andres Freund <andres(at)anarazel(dot)de>
Subject: Re: jit and explain nontext
Date: 2020-10-18 22:20:16
Message-ID: CAApHDvrMbS64A1kgj8C4hUaUd6n5uye7P1bJyn6zXuVq0mSwxQ@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Sun, 18 Oct 2020 at 08:21, Justin Pryzby <pryzby(at)telsasoft(dot)com> wrote:
> /* don't print information if no JITing happened */
> - if (!ji || ji->created_functions == 0)
> + if (!ji || (ji->created_functions == 0 &&
> + es->format == EXPLAIN_FORMAT_TEXT))
> return;

Isn't that comment now outdated?

I imagine something more like; /* Only show JIT details when we jitted
something or when in non-text mode */ might be better after making
that code change.

David

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Tom Lane 2020-10-18 23:10:06 Re: Assertion failure with LEFT JOINs among >500 relations
Previous Message David Rowley 2020-10-18 21:01:00 Re: Assertion failure with LEFT JOINs among >500 relations