Re: Reduce the number of special cases to build contrib modules on windows

From: David Rowley <dgrowleyml(at)gmail(dot)com>
To: Michael Paquier <michael(at)paquier(dot)xyz>
Cc: Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org>, Andres Freund <andres(at)anarazel(dot)de>, PostgreSQL Developers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: Reduce the number of special cases to build contrib modules on windows
Date: 2020-12-29 21:07:29
Message-ID: CAApHDvpkhDXQSuKOMvKMQbuG8EV1OKU7T2xLodS+SKPsbgi6sw@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Wed, 30 Dec 2020 at 10:03, David Rowley <dgrowleyml(at)gmail(dot)com> wrote:
>
> On Wed, 23 Dec 2020 at 18:46, Michael Paquier <michael(at)paquier(dot)xyz> wrote:
> > I have tested your patch, and this is causing compilation failures for
> > hstore_plpython, jsonb_plpython and ltree_plpython. So
> > AddTransformModule is missing something here when compiling with
> > Python.
>
> Oh thanks for finding that. That was due to some incorrect Perl code
> I'd written to add the includes from one project into another. Fixed
> by:

I accidentally attached the wrong patch before. Now attaching the correct one.

David

Attachment Content-Type Size
reduce_contrib_build_special_cases_on_windows_v6.patch text/plain 10.8 KB

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Tom Lane 2020-12-29 21:16:06 Re: Weird failure in explain.out with OpenBSD
Previous Message David Rowley 2020-12-29 21:03:34 Re: Reduce the number of special cases to build contrib modules on windows