Re: Add proper planner support for ORDER BY / DISTINCT aggregates

On Wed, 17 Aug 2022 at 13:57, Justin Pryzby <pryzby(at)telsasoft(dot)com> wrote:
> But in a few places, it removes the locally-computed group_pathkeys:
>
> - List *group_pathkeys = root->group_pathkeys;

> I noticed because that creates a new shadow variable, which seems accidental.

Thanks for the report.

I've just pushed a fix for this that basically just removes the line
you quoted. Really I should have been using the version of
group_pathkeys that stripped off the pathkeys from the ORDER BY /
DISTINCT aggregates that is calculated earlier in that function. In
practice, there was no actual bug here as the wrong variable was only
being used in the code path that was handling partial paths. We never
create any partial paths when there are aggregates with ORDER BY /
DISTINCT clauses, so in that code path, the two versions of the
group_pathkeys variable would have always been set to the same thing.

It makes sense just to get rid of the shadowed variable since the
value of it will be the same anyway.

David