| From: | Andrey Borodin <amborodin86(at)gmail(dot)com> |
|---|---|
| To: | Sergey Dudoladov <sergey(dot)dudoladov(at)gmail(dot)com> |
| Cc: | PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>, "David G(dot) Johnston" <david(dot)g(dot)johnston(at)gmail(dot)com>, Andres Freund <andres(at)anarazel(dot)de>, torikoshia <torikoshia(at)oss(dot)nttdata(dot)com>, "Drouvot, Bertrand" <bdrouvot(at)amazon(dot)com>, Julien Rouhaud <rjuju123(at)gmail(dot)com>, Kyotaro Horiguchi <horikyota(dot)ntt(at)gmail(dot)com>, Kuntal Ghosh <kuntalghosh(dot)2007(at)gmail(dot)com>, Rafia Sabih <rafia(dot)pghackers(at)gmail(dot)com> |
| Subject: | Re: Add connection active, idle time to pg_stat_activity |
| Date: | 2023-02-16 21:37:41 |
| Message-ID: | CAAhFRxibrZkLmJnH30T8dTK4JtQXCbmnquU9QvBg0vS18iu8wg@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Wed, Feb 1, 2023 at 12:46 PM Sergey Dudoladov
<sergey(dot)dudoladov(at)gmail(dot)com> wrote:
>
> I've sketched the first version of a patch to add pg_stat_session.
> Please review this early version.
Hi Sergey!
I've taken a look into the patch and got some notes.
1. It is hard to understand what fastpath backend state is. What do
fastpath metrics mean for a user?
2. Anyway, the path "if (PGSTAT_IS_FASTPATH(beentry))" seems
unreachable to me. I'm a bit surprised that compilers do not produce
warnings about it. Maybe I'm just wrong.
3. Tests do not check any incrementation logic. I think we can have
some test that verifies delta for select some_counter from
pg_stat_session where pid = pg_backend_pid();
4. Macroses like PGSTAT_IS_RUNNING do not look like net win in code
readability and PGSTAT prefix have no semantic load.
That's all I've found so far. Thank you!
Best regards, Andrey Borodin.
PS. We were doing on-air review session [0], I hope Nik will chime-in
with "usability part of a review".
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Jonah H. Harris | 2023-02-16 21:49:07 | Reducing System Allocator Thrashing of ExecutorState to Alleviate FDW-related Performance Degradations |
| Previous Message | Andres Freund | 2023-02-16 21:35:54 | Re: Missing free_var() at end of accum_sum_final()? |