| From: | Andrey Borodin <amborodin86(at)gmail(dot)com> |
|---|---|
| To: | Peter Geoghegan <pg(at)bowt(dot)ie> |
| Cc: | Jose Arthur Benetasso Villanova <jose(dot)arthur(at)gmail(dot)com>, Andres Freund <andres(at)anarazel(dot)de>, Andrey Borodin <x4mmm(at)yandex-team(dot)ru>, Nikolay Samokhvalov <samokhvalov(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: Amcheck verification of GiST and GIN |
| Date: | 2023-02-04 21:37:29 |
| Message-ID: | CAAhFRxhom_7K6VGsh5_Y9aw8w4UFyFvfoe9hQ-a9T3qfuzFL7g@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Thank for working on this, Peter!
On Fri, Feb 3, 2023 at 6:50 PM Peter Geoghegan <pg(at)bowt(dot)ie> wrote:
>
> I think that we should focus on getting the GiST patch into shape for
> commit first, since that seems easier.
>
Here's the next version. I've focused on GiST part in this revision.
Changes:
1. Refactored index_chackable so that is shared between all AMs.
2. Renamed gist_index_parent_check -> gist_index_check
3. Gathered reviewers (in no particular order). I hope I didn't forget
anyone. GIN patch is based on work by Grigory Kryachko, but
essentially rewritten by Heikki. Somewhat cosmetically whacked by me.
4. Extended comments for GistScanItem,
gist_check_parent_keys_consistency() and gist_refind_parent().
I tried adding support of GiST in pg_amcheck, but it is largely
assuming the relation is either heap or B-tree. I hope to do that part
tomorrow or in nearest future.
Here's the current version. Thank you!
Best regards, Andrey Borodin.
| Attachment | Content-Type | Size |
|---|---|---|
| v23-0001-Refactor-amcheck-to-extract-common-locking-routi.patch | application/octet-stream | 18.6 KB |
| v23-0002-Add-gist_index_check-function-to-verify-GiST-ind.patch | application/octet-stream | 28.5 KB |
| v23-0003-Add-gin_index_parent_check-to-verify-GIN-index.patch | application/octet-stream | 32.3 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Thomas Munro | 2023-02-05 00:00:50 | File descriptors in exec'd subprocesses |
| Previous Message | Laurenz Albe | 2023-02-04 20:46:16 | Re: Allow tailoring of ICU locales with custom rules |