Re: pgAdmin III commit: Lots of work on domains, and check constraints

From: Timon <timosha(at)gmail(dot)com>
To: pgadmin-hackers <pgadmin-hackers(at)postgresql(dot)org>
Cc: Guillaume Lelarge <guillaume(at)lelarge(dot)info>
Subject: Re: pgAdmin III commit: Lots of work on domains, and check constraints
Date: 2012-06-06 04:50:45
Message-ID: CAAeC-SvRqNRc-5edqcDD6YvWtbKbx22WAk=vmrsLtgZqPfemUA@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgadmin-hackers

seems that this commit broke reindexing of selected index. steps to reproduce:
1) create table
2) create index
3) select index in object inspector
4) try to reindex it via maintenance menu item
5) got error : ERROR: schema "table_name" does not exist

and one more crash here
.. same steps as before
4) try to CLUSTER index
5) pgadmin simply crashed

2012/5/1 Guillaume Lelarge <guillaume(at)lelarge(dot)info>:
> Lots of work on domains, and check constraints
>
> Check constraints on domains are now sub-nodes. A user can add as many check
> constraints as he wants. He can rename and validate them on 9.2. He can add
> a not-yet-valid check constraint. He can also add a NO INHERIT check constraint
> on a new table.
>
> Branch
> ------
> master
>
> Details
> -------
> http://git.postgresql.org/gitweb?p=pgadmin3.git;a=commitdiff;h=02b60e5a8b4f6c3cfafca1b93eff4833ddc7ae4f
>
> Modified Files
> --------------
> pgadmin/dlg/dlgCheck.cpp                   |   44 ++++--
> pgadmin/dlg/dlgDomain.cpp                  |  214 ++++++++++++++++++++++------
> pgadmin/dlg/dlgProperty.cpp                |   13 +-
> pgadmin/frm/events.cpp                     |    8 +-
> pgadmin/include/dlg/dlgCheck.h             |    6 +-
> pgadmin/include/dlg/dlgDomain.h            |    6 +
> pgadmin/include/schema/pgCheck.h           |   42 ++++--
> pgadmin/include/schema/pgConstraints.h     |   10 +-
> pgadmin/include/schema/pgDomain.h          |    1 +
> pgadmin/include/schema/pgForeignKey.h      |    6 +-
> pgadmin/include/schema/pgIndex.h           |   14 +-
> pgadmin/include/schema/pgIndexConstraint.h |   16 +-
> pgadmin/include/utils/misc.h               |    1 +
> pgadmin/schema/pgCheck.cpp                 |   80 +++++++----
> pgadmin/schema/pgConstraints.cpp           |   51 +++++---
> pgadmin/schema/pgDomain.cpp                |   95 ++++++++-----
> pgadmin/schema/pgForeignKey.cpp            |   15 ++-
> pgadmin/schema/pgIndex.cpp                 |   28 ++--
> pgadmin/schema/pgTable.cpp                 |    2 +
> pgadmin/ui/dlgCheck.xrc                    |   14 ++
> pgadmin/ui/dlgDomain.xrc                   |   95 ++++++++-----
> 21 files changed, 517 insertions(+), 244 deletions(-)
>
>
> --
> Sent via pgadmin-hackers mailing list (pgadmin-hackers(at)postgresql(dot)org)
> To make changes to your subscription:
> http://www.postgresql.org/mailpref/pgadmin-hackers

--
All bugs reserved

In response to

Responses

Browse pgadmin-hackers by date

  From Date Subject
Next Message Dickson S. Guedes 2012-06-06 06:33:07 PoC: Little improvements to EditGrid - Enum ComboBox
Previous Message Alexander LAW 2012-06-04 13:42:29 Pgadmin web site translation to Russian