Re: Other formats in pset like markdown, rst, mediawiki

From: Jan Michálek <godzilalalala(at)gmail(dot)com>
To: Peter Eisentraut <peter(dot)eisentraut(at)2ndquadrant(dot)com>
Cc: Pavel Stehule <pavel(dot)stehule(at)gmail(dot)com>, PostgreSQL mailing lists <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Other formats in pset like markdown, rst, mediawiki
Date: 2017-03-18 20:10:02
Message-ID: CAAYBy8ZokHzHU12Ds+-t7myLPMH+VKoA9E8=tzBFCHNxcqOP=Q@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox
Thread:
Lists: pgsql-hackers

2017-03-12 19:21 GMT+01:00 Jan Michálek <godzilalalala(at)gmail(dot)com>:

>
>
> 2017-03-10 9:43 GMT+01:00 Jan Michálek <godzilalalala(at)gmail(dot)com>:
>
>>
>>
>> 2017-03-09 20:10 GMT+01:00 Peter Eisentraut <
>> peter(dot)eisentraut(at)2ndquadrant(dot)com>:
>>
>>> This is looking pretty neat. I played around with it a bit. There are
>>> a couple of edge cases that you need to address, I think.
>>>
>>
>> Thanks, original code is very synoptical and and well prepared for adding
>> new formats.
>>
>>
>>>
>>> - Does not support \x
>>>
>>
>> I know, i dnot`t know, if \x make sense in this case. I will look, how it
>> is done in other formats like html. I think, that it should work in sense,
>> that table generated to rst should give similar output after processing
>> like output of html format.
>>
>>
> I prepared something like this (i have no prepared diff, i need do some
> another changes)
> There a few things I need to do. First problem is bold column names, i
> should do it in sme fashin as "RECORD", but i need to do some research
> about length of column.
> Bigger problem is with tab indent, rst processor doesn`t work with this in
> this case.
>

In new diff is added \x for rst and skipping leading spaces in rst in both.
make check passed

Jan

>
> jelen=# execute q \g | xclip
> +---------+-------------------------------------------------
> -----------------------+
> | **RECORD 1**
> |
> +---------+-------------------------------------------------
> -----------------------+
> | column1 | Elephant, kangaroo,
> |
> | | squirrel, gorilla
> |
> +---------+-------------------------------------------------
> -----------------------+
> | column2 | 121
> |
> +---------+-------------------------------------------------
> -----------------------+
> | column3 | 1.0035971223021583
> |
> +---------+-------------------------------------------------
> -----------------------+
> | column4 | 0.1111
> |
> +---------+-------------------------------------------------
> -----------------------+
> | column5 | Hello Hello Hello Hello Hello Hello Hello Hello Hello
> Hello |
> +---------+-------------------------------------------------
> -----------------------+
> | **RECORD 2**
> |
> +---------+-------------------------------------------------
> -----------------------+
> | column1 | goat, rhinoceros,
> |
> | | monkey, ape
> |
> +---------+-------------------------------------------------
> -----------------------+
> | column2 | 11121
> |
> +---------+-------------------------------------------------
> -----------------------+
> | column3 | 1.0007824726134585
> |
> +---------+-------------------------------------------------
> -----------------------+
> | column4 | 5.1111
> |
> +---------+-------------------------------------------------
> -----------------------+
> | column5 | xxxxxx xxxxxx xxxxxx xxxxxx xxxxxx xxxxxx xxxxxx xxxxxx xxxxxx
> xxxxxx |
> +---------+-------------------------------------------------
> -----------------------+
> | **RECORD 3**
> |
> +---------+-------------------------------------------------
> -----------------------+
> | column1 | donkey, cow, horse, tit,
> |
> | | eagle, whale,
> |
> | | aligator,
> |
> | | pelican,
> |
> | | grasshoper
> |
> | | pig
> |
> | | bat
> |
> +---------+-------------------------------------------------
> -----------------------+
> | column2 | 14351
> |
> +---------+-------------------------------------------------
> -----------------------+
> | column3 | 50.3877551020408163
> |
> +---------+-------------------------------------------------
> -----------------------+
> | column4 | 345.11
> |
> +---------+-------------------------------------------------
> -----------------------+
> | column5 | yyyyyy yyyyyy yyyyyy yyyyyy yyyyyy yyyyyy yyyyyy yyyyyy yyyyyy
> yyyyyy |
> +---------+-------------------------------------------------
> -----------------------+
>
>
>
>
>
>>
>>> - When \pset format is rst, then \pset linestyle also shows up as
>>> "rst". That is wrong. Same for markdown.
>>>
>>
>> I will look on this.
>>
>>
>>>
>>> - Broken output in tuples_only (\t) mode. (rst and markdown)
>>>
>>
>> Similar to \x, im not certain, what it should return. I will look, what
>> returns html format. Or i can use it in markdown for nice vs expanded
>> format.
>>
>>
>>>
>>> - rst: Do something about \pset title; the way it currently shows up
>>> appears to be invalid; could use ".. table:: title" directive
>>>
>>
>> OK, it shouldn`t be problem alter this.
>>
>>
>>>
>>> - markdown: Extra blank line between table and footer.
>>>
>>
>> It is because markdown needs empty line after table, if is row count
>> presented.
>>
>>
>>>
>>> - markdown: We should document or comment somewhere exactly which of the
>>> various markdown table formats this is supposed to produce. (Pandoc
>>> pipe_tables?)
>>>
>>
>> I use format that was similar to aligned format and ascii linestyle,
>> because it allows me to use existing features. I should look over more
>> table styles in markdown.
>>
>>
>>>
>>> - markdown: Table title needs to be after the table, like
>>>
>>> Table: title
>>>
>>> I will change this.
>>
>>
>>> - markdown: Needs to escape | characters in cell contents. (Not
>>> needed for rst.) More escaping might be needed.
>>>
>>
>> This can be problem because of aligning, i will look on this, this same
>> problem as replace newline with </br> for markdown.
>>
>> Have Nice day
>>
>> Jan
>>
>>
>>>
>>> --
>>> Peter Eisentraut http://www.2ndQuadrant.com/
>>> PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
>>>
>>
>>
>>
>> --
>> Jelen
>> Starší čeledín datovýho chlíva
>>
>
>
>
> --
> Jelen
> Starší čeledín datovýho chlíva
>

--
Jelen
Starší čeledín datovýho chlíva

Attachment Content-Type Size
patch_markdown_rst.diff text/plain 22.4 KB

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Magnus Hagander 2017-03-18 20:12:40 Removing binaries (was: createlang/droplang deprecated)
Previous Message Magnus Hagander 2017-03-18 20:06:46 Re: createlang/droplang deprecated