| From: | Jacob Champion <jchampion(at)timescale(dot)com> |
|---|---|
| To: | "Drouvot, Bertrand" <bdrouvot(at)amazon(dot)com> |
| Cc: | Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Joe Conway <mail(at)joeconway(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: SYSTEM_USER reserved word implementation |
| Date: | 2022-08-16 16:52:11 |
| Message-ID: | CAAWbhmiPwGCevz_FS3rRK5fWQ8RiLW2bPVABzJVDxVWCuMFdmg@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Fri, Aug 12, 2022 at 6:32 AM Drouvot, Bertrand <bdrouvot(at)amazon(dot)com> wrote:
> It has been agreed that the work on this patch is on hold until the
> ClientConnectionInfo related work is finished (see the discussion in [1]).
>
> Having said that I'm attaching a new patch
> "v2-0004-system_user-implementation.patch" for the SYSTEM_USER.
(Not a full review.) Now that the implementation has increased in
complexity, the original tests for the parallel workers have become
underpowered. As a concrete example, I forgot to serialize auth_method
during my most recent rewrite, and the tests still passed.
I think it'd be better to check the contents of SYSTEM_USER, where we
can, rather than only testing for existence. Something like the
attached, maybe? And it would also be good to add a similar test to
the authentication suite, so that you don't have to have Kerberos
enabled to fully test SYSTEM_USER.
--Jacob
| Attachment | Content-Type | Size |
|---|---|---|
| kerb-tests.patch.txt | text/plain | 1.3 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Jacob Champion | 2022-08-16 16:58:28 | Re: [PATCH] Expose port->authn_id to extensions and triggers |
| Previous Message | Alvaro Herrera | 2022-08-16 16:40:49 | Re: Add find_in_log() and advance_wal() perl functions to core test framework (?) |