Re: [PATCH] Fix unbounded authentication exchanges during PQconnectPoll()

From: Jacob Champion <jchampion(at)timescale(dot)com>
To: Heikki Linnakangas <hlinnaka(at)iki(dot)fi>
Cc: PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>, Peter Eisentraut <peter(dot)eisentraut(at)enterprisedb(dot)com>
Subject: Re: [PATCH] Fix unbounded authentication exchanges during PQconnectPoll()
Date: 2023-02-22 21:09:25
Message-ID: CAAWbhmh4_bLK3Nh-6gUPasF4W56rQwRiTVKti1+gNuoseGnJXw@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Wed, Feb 22, 2023 at 11:43 AM Heikki Linnakangas <hlinnaka(at)iki(dot)fi> wrote:
> I separated the earlier message-length checks so that you get "invalid
> invalid authentication request" or "received invalid protocol
> negotiation message", depending on whether it was an 'R' or 'v' message.
> With that, "invalid invalid authentication request" becomes translatable
> anyway, which makes the point on translation overhead moot. I added a
> comment to mention that it's unreachable, though.

Looks good, thank you!

--Jacob

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Thomas Munro 2023-02-22 21:17:44 Re: Add SHELL_EXIT_CODE to psql
Previous Message Tom Lane 2023-02-22 20:55:44 Re: pg_regress: Treat child process failure as test failure