Re: Fix some inconsistencies with open-coded visibilitymap_set() callers

From: Melanie Plageman <melanieplageman(at)gmail(dot)com>
To: PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Cc: Robert Haas <robertmhaas(at)gmail(dot)com>, Andres Freund <andres(at)anarazel(dot)de>
Subject: Re: Fix some inconsistencies with open-coded visibilitymap_set() callers
Date: 2025-06-26 19:56:07
Message-ID: CAAKRu_awNQte98bXxrzZFwaC6h+GOxCHkO6E=bK=06MDE3B8zg@mail.gmail.com
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Tue, Jun 24, 2025 at 4:01 PM Melanie Plageman
<melanieplageman(at)gmail(dot)com> wrote:
>
> visibilitymap_set() arguably breaks a few of the coding rules for
> modifying and WAL logging buffers set out in
> src/backend/access/transam/README.

Here is a rebased version of this (it had some conflicts with recent commits).

- Melanie

Attachment Content-Type Size
v2-0001-Introduce-heap-specific-wrapper-for-visibilitymap.patch text/x-patch 16.0 KB

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Nathan Bossart 2025-06-26 20:16:35 Re: [PATCH] Use binaryheap_* macro where appropriate
Previous Message Jianghua Yang 2025-06-26 19:51:10 [PATCH] Use DatumGetUInt32() for dsm_attach() in test_shm_mq_main()