| From: | Melanie Plageman <melanieplageman(at)gmail(dot)com> |
|---|---|
| To: | Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org> |
| Cc: | Andres Freund <andres(at)anarazel(dot)de>, Kyotaro Horiguchi <horikyota(dot)ntt(at)gmail(dot)com>, Magnus Hagander <magnus(at)hagander(dot)net>, Pg Hackers <pgsql-hackers(at)postgresql(dot)org>, Lukas Fittl <lukas(at)fittl(dot)com>, Thomas Munro <thomas(dot)munro(at)gmail(dot)com> |
| Subject: | Re: pg_stat_bgwriter.buffers_backend is pretty meaningless (and more?) |
| Date: | 2021-09-29 20:46:07 |
| Message-ID: | CAAKRu_a3TeYza8+M+6ELq=mze-US=cNzc+jsvyZkLCjtd+cT9g@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Mon, Sep 27, 2021 at 2:58 PM Melanie Plageman
<melanieplageman(at)gmail(dot)com> wrote:
>
> On Fri, Sep 24, 2021 at 5:58 PM Melanie Plageman
> <melanieplageman(at)gmail(dot)com> wrote:
> >
> > On Thu, Sep 23, 2021 at 5:05 PM Melanie Plageman
> > <melanieplageman(at)gmail(dot)com> wrote:
> > The only remaining TODOs are described in the commit message.
> > most critical one is that the reset message doesn't work.
>
> v10 is attached with updated comments and some limited code refactoring
v11 has fixed the oversize message issue by sending a reset message for
each backend type. Now, we will call GetCurrentTimestamp
BACKEND_NUM_TYPES times, so maybe I should add some kind of flag to the
reset message that indicates the first message so that all the "do once"
things can be done at that point.
I've also fixed a few style/cosmetic issues and updated the commit
message with a link to the thread [1] where I proposed smgrwrite() and
smgrextend() wrappers (which is where I propose to call
pgstat_incremement_buffer_access_type() for unbuffered writes and
extends).
- Melanie
| Attachment | Content-Type | Size |
|---|---|---|
| v11-0003-Remove-superfluous-bgwriter-stats.patch | text/x-patch | 15.6 KB |
| v11-0002-Add-system-view-tracking-accesses-to-buffers.patch | text/x-patch | 42.0 KB |
| v11-0001-Allow-bootstrap-process-to-beinit.patch | text/x-patch | 820 bytes |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | David Rowley | 2021-09-29 20:48:03 | Re: jsonb crash |
| Previous Message | Tom Lane | 2021-09-29 20:33:52 | Re: prevent immature WAL streaming |