| From: | Melanie Plageman <melanieplageman(at)gmail(dot)com> |
|---|---|
| To: | Peter Eisentraut <peter(dot)eisentraut(at)enterprisedb(dot)com> |
| Cc: | Andres Freund <andres(at)anarazel(dot)de>, Pg Hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: heapgettup refactoring |
| Date: | 2023-01-03 20:39:37 |
| Message-ID: | CAAKRu_ZjbE6v4S7+R7q=RBSBj7dV5u4Y2v5MNFE5oVm1m-9D=A@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Mon, Jan 2, 2023 at 5:23 AM Peter Eisentraut
<peter(dot)eisentraut(at)enterprisedb(dot)com> wrote:
>
> On 30.11.22 23:34, Melanie Plageman wrote:
> > I have attached a patchset with only the code changes contained in the
> > previous patch 0003. I have broken the refactoring down into many
> > smaller pieces for ease of review.
>
> To keep this moving along a bit, I have committed your 0002, which I
> think is a nice little improvement on its own.
Thanks!
I've attached a rebased patchset - v4.
I also changed heapgettup_no_movement() to noinline (instead of inline).
David Rowley pointed out that this might make more sense given how
comparatively rare no movement scans are.
- Melanie
| Attachment | Content-Type | Size |
|---|---|---|
| v4-0004-Add-heapgettup-helpers.patch | application/octet-stream | 3.9 KB |
| v4-0002-Add-heapgettup_initial_page-helper.patch | application/octet-stream | 9.1 KB |
| v4-0005-Add-heapgettup_advance_page.patch | application/octet-stream | 6.8 KB |
| v4-0006-Refactor-heapgettup-and-heapgettup_pagemode.patch | application/octet-stream | 9.8 KB |
| v4-0003-Streamline-heapgettup-for-refactor.patch | application/octet-stream | 8.5 KB |
| v4-0001-Add-no-movement-scan-helper.patch | application/octet-stream | 5.0 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Andreas Karlsson | 2023-01-03 21:03:55 | Re: RADIUS tests and improvements |
| Previous Message | Brar Piening | 2023-01-03 20:35:09 | Re: doc: add missing "id" attributes to extension packaging page |