From: | Melanie Plageman <melanieplageman(at)gmail(dot)com> |
---|---|
To: | Nathan Bossart <nathandbossart(at)gmail(dot)com> |
Cc: | Pg Hackers <pgsql-hackers(at)postgresql(dot)org>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
Subject: | Re: Move un-parenthesized syntax docs to "compatibility" for few SQL commands |
Date: | 2023-04-21 23:29:59 |
Message-ID: | CAAKRu_Y_L7aiogku8SginjeCehKKUgs_=_H=KzxVEVjJUYZo=A@mail.gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
On Fri, Apr 21, 2023 at 6:55 PM Nathan Bossart <nathandbossart(at)gmail(dot)com> wrote:
>
> On Fri, Apr 21, 2023 at 06:29:16PM -0400, Melanie Plageman wrote:
> > Over in [2], it was suggested that moving the un-parenthesized syntax to
> > the "Compatibility" section of their respective docs pages would be
> > okay. Patch attached.
>
> I think that's reasonable.
>
> > I left out CLUSTER since that syntax change is so new.
>
> I think it'd be okay to move this one, too. The parenthesized syntax has
> been available since v14, and I suspect CLUSTER isn't terribly widely used,
> anyway. (Side note: it looks like "CLUSTER (VERBOSE)" doesn't work, which
> seems weird to me.)
Attached v2 includes changes for CLUSTER syntax docs. I wasn't quite
sure that we can move down CLUSTER [VERBOSE] syntax to the compatibility
section since CLUSTER (VERBOSE) doesn't work. This seems like it should
work (VACUUM and ANALYZE do). I put extra "[ ]" around the main CLUSTER
syntax but I don't know that this is actually the same as documenting
that CLUSTER VERBOSE does work but CLUSTER (VERBOSE) doesn't.
> Most of these commands have an existing note about the deprecated syntax.
> Could those be removed with this change?
Ah, yes. Good catch! I have removed these.
- Melanie
Attachment | Content-Type | Size |
---|---|---|
v2-0001-Doc-Move-un-parenthesized-syntax-to-compatibility.patch | text/x-patch | 7.4 KB |
From | Date | Subject | |
---|---|---|---|
Next Message | Nathan Bossart | 2023-04-21 23:45:15 | Re: Move un-parenthesized syntax docs to "compatibility" for few SQL commands |
Previous Message | Tom Lane | 2023-04-21 23:19:53 | Re: Memory leak in CachememoryContext |