Re: [Patch] ALTER SYSTEM READ ONLY

From: Amul Sul <sulamul(at)gmail(dot)com>
To: Ibrar Ahmed <ibrar(dot)ahmad(at)gmail(dot)com>
Cc: Robert Haas <robertmhaas(at)gmail(dot)com>, Dilip Kumar <dilipbalaut(at)gmail(dot)com>, Andres Freund <andres(at)anarazel(dot)de>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: [Patch] ALTER SYSTEM READ ONLY
Date: 2021-03-15 12:15:22
Message-ID: CAAJ_b97zD5ybAFONEJO-0W94a3=M0DDL6S47LNYTS8+Y2Wv=dA@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

I made a few changes and fixes in the attached version.
The document patch is now ready for review.

Regards,
Amul

On Mon, Mar 15, 2021 at 12:55 PM Amul Sul <sulamul(at)gmail(dot)com> wrote:
>
> On Sun, Mar 14, 2021 at 11:51 PM Ibrar Ahmed <ibrar(dot)ahmad(at)gmail(dot)com> wrote:
> >
> > On Tue, Mar 9, 2021 at 3:31 PM Amul Sul <sulamul(at)gmail(dot)com> wrote:
> >>
> >> On Thu, Mar 4, 2021 at 11:02 PM Amul Sul <sulamul(at)gmail(dot)com> wrote:
> >> >
> >> > On Wed, Mar 3, 2021 at 8:56 PM Robert Haas <robertmhaas(at)gmail(dot)com> wrote:
> >> > >
> >> > > On Tue, Mar 2, 2021 at 7:22 AM Dilip Kumar <dilipbalaut(at)gmail(dot)com> wrote:
> >[....]
> >
> > One of the patch (v18-0002-Error-or-Assert-before-START_CRIT_SECTION-for-WA.patch) from the latest patchset does not apply successfully.
> >
> > http://cfbot.cputube.org/patch_32_2602.log
> >
> > === applying patch ./v18-0002-Error-or-Assert-before-START_CRIT_SECTION-for-WA.patch
> >
> > Hunk #15 succeeded at 2604 (offset -13 lines).
> > 1 out of 15 hunks FAILED -- saving rejects to file src/backend/access/nbtree/nbtpage.c.rej
> > patching file src/backend/access/spgist/spgdoinsert.c
> >
> > It is a very minor change, so I rebased the patch. Please take a look, if that works for you.
> >
>
> Thanks, I am getting one more failure for the vacuumlazy.c. on the
> latest master head(d75288fb27b), I fixed that in attached version.
>
> Regards,
> Amul

Attachment Content-Type Size
v21-0001-Implement-wal-prohibit-state-using-global-barrie.patch application/x-patch 51.5 KB
v21-0002-Error-or-Assert-before-START_CRIT_SECTION-for-WA.patch application/x-patch 69.9 KB
v21-0003-Documentation.patch application/x-patch 10.3 KB

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message gkokolatos 2021-03-15 12:18:12 Re: PATCH: Attempt to make dbsize a bit more consistent
Previous Message Dilip Kumar 2021-03-15 12:14:33 Re: [HACKERS] Custom compression methods