Re: Improve catcache/syscache performance.

From: amul sul <sulamul(at)gmail(dot)com>
To: Andres Freund <andres(at)anarazel(dot)de>
Cc: PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Improve catcache/syscache performance.
Date: 2017-09-20 12:56:50
Message-ID: CAAJ_b97qe-djtnrMb6O-K0Q7ebtpGSWEXxLZ-2vSvby_K44CxQ@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox
Thread:
Lists: pgsql-hackers

Patch 0007:

1:
400 + /*
401 + * XXX: might be worthwhile to only handle oid sysattr, to
reduce
402 + * overhead - it's the most common key.
403 + */

IMHO, let fix that as well. I tested this by fixing (see the attach patch)
but does
not found much gain on my local centos vm (of course, the pgbench load
wasn't big enough).

2: How about have wrapping following condition in SearchCatCacheMiss() by
unlikely():

if (IsBootstrapProcessingMode())
return NULL;

3: Can we have following assert in SearchCatCacheN() instead
SearchSysCacheN(), so that we'll assert direct SearchCatCacheN() call as
well?

Assert(SysCache[cacheId]->cc_nkeys == <N>);

Other than these concern, patch looks pretty reasonable to me.

Regards,
Amul

Attachment Content-Type Size
0007_ex_handle_oid.patch application/octet-stream 969 bytes

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Fabien COELHO 2017-09-20 12:59:03 Re: psql - add ability to test whether a variable exists
Previous Message Ashutosh Bapat 2017-09-20 12:55:47 Re: Partition-wise join for join between (declaratively) partitioned tables