Re: [Patch] ALTER SYSTEM READ ONLY

From: Amul Sul <sulamul(at)gmail(dot)com>
To: Ibrar Ahmed <ibrar(dot)ahmad(at)gmail(dot)com>
Cc: Robert Haas <robertmhaas(at)gmail(dot)com>, Dilip Kumar <dilipbalaut(at)gmail(dot)com>, Andres Freund <andres(at)anarazel(dot)de>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: [Patch] ALTER SYSTEM READ ONLY
Date: 2021-03-15 07:25:42
Message-ID: CAAJ_b96df3fWJz+7gh0nUCyJ1jRMEq63YzTpkqFZD02gYKWtSg@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Sun, Mar 14, 2021 at 11:51 PM Ibrar Ahmed <ibrar(dot)ahmad(at)gmail(dot)com> wrote:
>
> On Tue, Mar 9, 2021 at 3:31 PM Amul Sul <sulamul(at)gmail(dot)com> wrote:
>>
>> On Thu, Mar 4, 2021 at 11:02 PM Amul Sul <sulamul(at)gmail(dot)com> wrote:
>> >
>> > On Wed, Mar 3, 2021 at 8:56 PM Robert Haas <robertmhaas(at)gmail(dot)com> wrote:
>> > >
>> > > On Tue, Mar 2, 2021 at 7:22 AM Dilip Kumar <dilipbalaut(at)gmail(dot)com> wrote:
>[....]
>
> One of the patch (v18-0002-Error-or-Assert-before-START_CRIT_SECTION-for-WA.patch) from the latest patchset does not apply successfully.
>
> http://cfbot.cputube.org/patch_32_2602.log
>
> === applying patch ./v18-0002-Error-or-Assert-before-START_CRIT_SECTION-for-WA.patch
>
> Hunk #15 succeeded at 2604 (offset -13 lines).
> 1 out of 15 hunks FAILED -- saving rejects to file src/backend/access/nbtree/nbtpage.c.rej
> patching file src/backend/access/spgist/spgdoinsert.c
>
> It is a very minor change, so I rebased the patch. Please take a look, if that works for you.
>

Thanks, I am getting one more failure for the vacuumlazy.c. on the
latest master head(d75288fb27b), I fixed that in attached version.

Regards,
Amul

Attachment Content-Type Size
v20-0001-Implement-wal-prohibit-state-using-global-barrie.patch application/x-patch 51.5 KB
v20-0003-WIP-Documentation.patch application/x-patch 10.3 KB
v20-0002-Error-or-Assert-before-START_CRIT_SECTION-for-WA.patch application/x-patch 69.2 KB

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Michael Paquier 2021-03-15 07:38:08 Re: PITR promote bug: Checkpointer writes to older timeline
Previous Message Bharath Rupireddy 2021-03-15 07:25:27 Re: Consider Parallelism While Planning For REFRESH MATERIALIZED VIEW