Re: [PATCH] rewriteGraphTable: Fix missing RTEs in FROM clause by setting inFromCl=true

From: Henson Choi <assam258(at)gmail(dot)com>
To: zengman <zengman(at)halodbtech(dot)com>
Cc: pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>, Junwang Zhao <zhjwpku(at)gmail(dot)com>, Ashutosh Bapat <ashutosh(dot)bapat(dot)oss(at)gmail(dot)com>, Peter Eisentraut <peter(at)eisentraut(dot)org>
Subject: Re: [PATCH] rewriteGraphTable: Fix missing RTEs in FROM clause by setting inFromCl=true
Date: 2026-03-20 09:54:20
Message-ID: CAAAe_zCOGCXvj4c=B=Swi6M8POCFb2SdJm1xkJkNi3NOLTL5Yw@mail.gmail.com
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Hi Man,

I checked the comment:
>
> * inFromCl marks those range variables that are listed in the FROM clause.
> * It's false for RTEs that are added to a query behind the scenes, such
> * as the NEW and OLD variables for a rule, or the subqueries of a UNION.
>
> Even the RTEs are not directly listed in FROM, but as we are rewriting the
> match pattern using join and where clause, I tend to agree with the fix.

Would you consider adding this to the commitfest?

Best regards,
Henson

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Evgeny Voropaev 2026-03-20 10:05:41 Re: Compress prune/freeze records with Delta Frame of Reference algorithm
Previous Message lakshmi 2026-03-20 09:54:05 Re: Avoid multiple calls to memcpy (src/backend/access/index/genam.c)