Re: [DEPARSE] Operators on ROW() constructors read back as row comparisons

Hi Tom,

> I'm not too concerned about that, given that the sum total of field
> complaints about this is zero. I doubt very many people are writing
> explicit casts to record, rather than explicit casts to some named
> composite type, and probably even fewer are doing it in this context
> for this purpose.

Understood. Then I'll drop the ruleutils.c change (v2-0004). v3 is
attached:

0001 tests
0002 record the casts the user writes in the parse tree (same as
v2-0002)
0003 show casts of the ROW()s the parser makes itself (same as
v2-0003)

0003 covers a whole-row reference to a JOIN USING alias and a
whole-row reference coerced to an operator's composite input type.
These come up without the user writing any cast, and they do not read
back even for views created now. The path in 0002 does not reach
them, so I kept it separate. If you think these cases need not be
handled, 0003 can be dropped.

The tests are smaller now. Each case creates a view and shows only
its pg_get_viewdef() output, and the objects are left in place so that
the pg_upgrade test dumps and restores them. As Prashant suggested,
there is also a generated column, to show the output of pg_get_expr().

Best regards,
Henson