| From: | Andrew Dunstan <andrew(dot)dunstan(at)2ndquadrant(dot)com> |
|---|---|
| To: | David Rowley <david(dot)rowley(at)2ndquadrant(dot)com> |
| Cc: | Andres Freund <andres(at)anarazel(dot)de>, Thomas Munro <thomas(dot)munro(at)enterprisedb(dot)com>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: ALTER TABLE ADD COLUMN fast default |
| Date: | 2018-03-13 12:28:03 |
| Message-ID: | CAA8=A7_=0Rjo5iWXY-AmoyJhyZApa69P6VGDGPr7rw3HDD6upw@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Tue, Mar 13, 2018 at 2:40 PM, Andrew Dunstan
<andrew(dot)dunstan(at)2ndquadrant(dot)com> wrote:
>>
>> Going by the commitfest app, the patch still does appear to be waiting
>> on Author. Never-the-less, I've made another pass over it and found a
>> few mistakes and a couple of ways to improve things:
>>
>
> working on these. Should have a new patch tomorrow.
>
Here is a patch that attends to most of these, except that I haven't
re-indented it.
Your proposed changes to slot_getmissingattrs() wouldn't work, but I
have rewritten it in a way that avoids the double work you disliked.
I'll rerun the benchmark tests I posted upthread and let you know the results.
cheers
andrew
--
Andrew Dunstan https://www.2ndQuadrant.com
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
| Attachment | Content-Type | Size |
|---|---|---|
| fast_default-v15.patch | application/octet-stream | 106.8 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Christos Maris | 2018-03-13 12:46:26 | Re: Google Summer of Code: Potential Applicant |
| Previous Message | Andrey Borodin | 2018-03-13 12:26:15 | Re: [HACKERS] GSoC 2017: weekly progress reports (week 6) |