| From: | Sami Imseih <samimseih(at)gmail(dot)com> |
|---|---|
| To: | Dmitry Dolgov <9erthalion6(at)gmail(dot)com> |
| Cc: | Michael Paquier <michael(at)paquier(dot)xyz>, Junwang Zhao <zhjwpku(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: queryId constant squashing does not support prepared statements |
| Date: | 2025-05-22 01:22:19 |
| Message-ID: | CAA5RZ0vFAGAJ2A1AJ7fVM8M7dt7rropqiqVcke89Z-Y6Um376A@mail.gmail.com |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
> > > At the same time AFAICT there isn't much more code paths
> > > to worry about in case of a LocationExpr as a node
> >
> > I can imagine there are others like value expressions,
> > row expressions, json array expressions, etc. that we may
> > want to also normalize.
> Exactly. When using a node, one can explicitly wrap whatever is needed
> into it, while otherwise one would need to find a new way to piggy back
> on A_Expr in a new context.
Looking at the VALUES expression case, we will need to carry the info
with SelectStmt and ultimately to RangeTblEntry which is where the
values_list is, so either approach we take RangeTblEntry will need the
LocationExpr pointer or the additional ParseLoc info I am suggesting.
A_Expr is not used in the values list case.
> I'll take a look at the proposed change, but a bit later.
Here is a v4 to compare with v3.
0001- is the infrastructure to track the boundaries
0002- the changes to jumbling
0003 - the additional tests introduced in v3
--
Sami
| Attachment | Content-Type | Size |
|---|---|---|
| v4-0002-Support-external-parameters-for-query-squashing.patch | application/x-patch | 15.0 KB |
| v4-0003-Extend-ARRAY-squashing-tests.patch | application/x-patch | 10.4 KB |
| v4-0001-Add-tracking-for-expression-boundaries.patch | application/x-patch | 8.9 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Michael Paquier | 2025-05-22 01:30:40 | Re: Issues with 2PC at recovery: CLOG lookups and GlobalTransactionData |
| Previous Message | Andy Fan | 2025-05-22 00:54:49 | Re: plan shape work |