Re: pg_waldump: support decoding of WAL inside tarfile

From: Sami Imseih <samimseih(at)gmail(dot)com>
To: Thomas Munro <thomas(dot)munro(at)gmail(dot)com>
Cc: Nazir Bilal Yavuz <byavuz81(at)gmail(dot)com>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Tomas Vondra <tomas(at)vondra(dot)me>, Andres Freund <andres(at)anarazel(dot)de>, Michael Paquier <michael(at)paquier(dot)xyz>, Andrew Dunstan <andrew(at)dunslane(dot)net>, Amul Sul <sulamul(at)gmail(dot)com>, Zsolt Parragi <zsolt(dot)parragi(at)percona(dot)com>, Robert Haas <robertmhaas(at)gmail(dot)com>, Chao Li <li(dot)evan(dot)chao(at)gmail(dot)com>, Anthonin Bonnefoy <anthonin(dot)bonnefoy(at)datadoghq(dot)com>, Fujii Masao <masao(dot)fujii(at)gmail(dot)com>, Jakub Wartak <jakub(dot)wartak(at)enterprisedb(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: pg_waldump: support decoding of WAL inside tarfile
Date: 2026-04-03 14:59:19
Message-ID: CAA5RZ0tXWJdL5mTJ8p9RrnThPoja-2LDykUykcbJt5iSjmWe6Q@mail.gmail.com
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Hi,

> On Sat, Apr 4, 2026 at 12:38 AM Nazir Bilal Yavuz <byavuz81(at)gmail(dot)com> wrote:
> > I also tried Thomas'
> > "v2-0001-Improve-tar-portability-logic-from-ebba64c0" [3] but it
> > didn't fix the problem on OpenBSD [4].
>
> Apparently it wants -F ustar, like this. Funny that it passed on the
> build farm animals though. Oh, it looks like they changed the default
> fairly recently.

LGTM with just a correction of my earlier comment.

< + # ustar format supports UIDs only up to 2^21 (2097151). Override
---
> + # ustar format supports UIDs only up to 2^21 - 1 (2097151). Override

--
Sami

Attachment Content-Type Size
v4-0001-Improve-tar-portability-logic-from-ebba64c0.patch application/octet-stream 2.4 KB

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Nazir Bilal Yavuz 2026-04-03 15:30:01 Re: pg_waldump: support decoding of WAL inside tarfile
Previous Message Alvaro Herrera 2026-04-03 14:59:09 Re: Adding REPACK [concurrently]