| From: | Sami Imseih <samimseih(at)gmail(dot)com> |
|---|---|
| To: | Mircea Cadariu <cadariu(dot)mircea(at)gmail(dot)com> |
| Cc: | Michael Paquier <michael(at)paquier(dot)xyz>, Guillaume Lelarge <guillaume(dot)lelarge(at)dalibo(dot)com>, Frédéric Yhuel <frederic(dot)yhuel(at)dalibo(dot)com>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>, Benoit Lobréau <benoit(dot)lobreau(at)dalibo(dot)com>, Pierrick Chovelon <pierrick(dot)chovelon(at)dalibo(dot)com> |
| Subject: | Re: [BUG] temporary file usage report with extended protocol and unnamed portals |
| Date: | 2025-10-29 21:58:22 |
| Message-ID: | CAA5RZ0saywFCjKFrSS9p2Yv4o35o0yh9JnHW+SEs9KCeOhbD=A@mail.gmail.com |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
> > v16 is based on [0], with updates to the documentation and tests.
>
> Thanks for the updated patch!
>
> > +ok( $node->log_contains(qr/STATEMENT:\s+SELECT a FROM foo ORDER BY a
> > OFFSET \$1/s, $log_offset),
> > "bind and implicit transaction, no statement logged");
> Should it actually be "statement correctly logged" instead of "no
> statement logged"?
oops, you're right.
We can actually remove "temporary file removed"
and "no statement logged" since we expect the
logging to blame the correct query in all these cases.
See v17
--
Sami Imseih
Amazon Web Services (AWS)
| Attachment | Content-Type | Size |
|---|---|---|
| v17-0001-Drop-unnamed-portal-immediately-after-execution-.patch | application/octet-stream | 5.1 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Sami Imseih | 2025-10-29 22:02:37 | Re: Bug in pg_stat_statements |
| Previous Message | Tom Lane | 2025-10-29 21:37:36 | Re: abi-compliance-check failure due to recent changes to pg_{clear,restore}_{attribute,relation}_stats() |