| From: | Amit Kapila <amit(dot)kapila16(at)gmail(dot)com> |
|---|---|
| To: | Pavel Stehule <pavel(dot)stehule(at)gmail(dot)com> |
| Cc: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, vignesh C <vignesh21(at)gmail(dot)com>, Dilip Kumar <dilipbalaut(at)gmail(dot)com>, Ryan Lambert <ryan(at)rustprooflabs(dot)com>, Thomas Munro <thomas(dot)munro(at)gmail(dot)com>, Anthony Nowocien <anowocien(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>, Filip Rembiałkowski <filip(dot)rembialkowski(at)gmail(dot)com> |
| Subject: | Re: dropdb --force |
| Date: | 2019-11-08 05:38:47 |
| Message-ID: | CAA4eK1LwYbXMPxM7K38nUcfqhST1ZyptiHKBzVxLYKqHZoMZrg@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Thu, Nov 7, 2019 at 11:29 AM Pavel Stehule <pavel(dot)stehule(at)gmail(dot)com> wrote:
> čt 7. 11. 2019 v 6:56 odesílatel Amit Kapila <amit(dot)kapila16(at)gmail(dot)com> napsal:
>>
>> Okay, no problem. I will pick the previous version and do this. I
>> will post the patch in a day or so for your review.
>
>
> Thank you very much
>
Did you get a chance to look at the other related patch posted by me
[1]? I have asked it before as well because I think that need to go
before this. We need to avoid errors to happen after terminating the
connections as otherwise, the termination of other databases will go
be of no use.
I have added the comment and changed one condition in tab-completion
as otherwise, it was allowing tab completion for the following syntax:
"drop database db1 , FORCE" which doesn't make sense to me. Please,
find the result attached. Let me know what you think?
--
With Regards,
Amit Kapila.
EnterpriseDB: http://www.enterprisedb.com
| Attachment | Content-Type | Size |
|---|---|---|
| drop-database-force-20191108.amit.patch | application/octet-stream | 17.1 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Pavel Stehule | 2019-11-08 05:40:20 | Re: dropdb --force |
| Previous Message | Amit Langote | 2019-11-08 05:31:35 | Re: adding partitioned tables to publications |