Re: [PATCH] Use indexes on the subscriber when REPLICA IDENTITY is full on the publisher

From: Amit Kapila <amit(dot)kapila16(at)gmail(dot)com>
To: Önder Kalacı <onderkalaci(at)gmail(dot)com>
Cc: vignesh C <vignesh21(at)gmail(dot)com>, "shiy(dot)fnst(at)fujitsu(dot)com" <shiy(dot)fnst(at)fujitsu(dot)com>, Peter Smith <smithpb2250(at)gmail(dot)com>, "wangw(dot)fnst(at)fujitsu(dot)com" <wangw(dot)fnst(at)fujitsu(dot)com>, Marco Slot <marco(dot)slot(at)gmail(dot)com>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Andres Freund <andres(at)anarazel(dot)de>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: [PATCH] Use indexes on the subscriber when REPLICA IDENTITY is full on the publisher
Date: 2023-03-18 09:49:43
Message-ID: CAA4eK1LmdYY1M-hwYzx08Y164Gi-Jrgs5ts0GmEmcfTu1G7Rtg@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Thu, Mar 16, 2023 at 2:15 PM Amit Kapila <amit(dot)kapila16(at)gmail(dot)com> wrote:
>
> On Wed, Mar 15, 2023 at 9:12 AM Amit Kapila <amit(dot)kapila16(at)gmail(dot)com> wrote:
> >
> > On Tue, Mar 14, 2023 at 3:18 PM Önder Kalacı <onderkalaci(at)gmail(dot)com> wrote:
> > >>
> >
> > Pushed this patch but forgot to add a new testfile. Will do that soon.
> >
>
> The main patch is committed now. I think the pending item in this
> thread is to conclude whether we need a storage or subscription to
> disable/enable this feature. Both Andres and Onder don't seem to be in
> favor but I am of opinion that it could be helpful in scenarios where
> the index scan (due to duplicates or dead tuples) is slower. However,
> if we don't have a consensus on the same, we can anyway add it later.
> If there are no more votes in favor of adding such an option, we can
> probably close the CF entry.
>

I have closed this CF entry for now. However, if there is any interest
in pursuing the storage or subscription option for this feature, we
can still discuss it.

--
With Regards,
Amit Kapila.

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Amit Kapila 2023-03-18 10:11:09 Re: Allow logical replication to copy tables in binary format
Previous Message Peter Smith 2023-03-18 09:41:23 Re: Allow logical replication to copy tables in binary format