| From: | Amit Kapila <amit(dot)kapila16(at)gmail(dot)com> |
|---|---|
| To: | John Naylor <john(dot)naylor(at)enterprisedb(dot)com> |
| Cc: | Michael Paquier <michael(at)paquier(dot)xyz>, YANG Xudong <yangxudong(at)ymatrix(dot)cn>, pgsql-hackers(at)lists(dot)postgresql(dot)org, wengyanqing(at)ymatrix(dot)cn, wanghao(at)ymatrix(dot)cn |
| Subject: | Re: [PATCH] Add loongarch native checksum implementation. |
| Date: | 2023-08-11 02:43:28 |
| Message-ID: | CAA4eK1LT_cTbdqiWL=pSu8aFxxUn6wo2LDJcnjkrhwOZuFAxUQ@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Thu, Aug 10, 2023 at 5:07 PM John Naylor
<john(dot)naylor(at)enterprisedb(dot)com> wrote:
>
> On Thu, Aug 10, 2023 at 5:54 PM Michael Paquier <michael(at)paquier(dot)xyz> wrote:
> >
> > On Thu, Aug 10, 2023 at 03:56:37PM +0530, Amit Kapila wrote:
> > > In MSVC build, on doing: perl mkvcbuild.pl after this commit, I am
> > > facing the below error:
> > > Generating configuration headers...
> > > undefined symbol: USE_LOONGARCH_CRC32C at src/include/pg_config.h line
> > > 718 at ../postgresql/src/tools/msvc/Mkvcbuild.pm line 872.
> > >
> > > Am I missing something or did the commit miss something?
> >
> > Yes, the commit has missed the addition of USE_LOONGARCH_CRC32C in
> > Solution.pm. If you want to be consistent with pg_config.h.in, you
> > could add it just after USE_LLVM, for instance.
>
> Oops, fixing now...
>
It is fixed now. Thanks!
--
With Regards,
Amit Kapila.
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Noah Misch | 2023-08-11 02:44:20 | Re: Cirrus-ci is lowering free CI cycles - what to do with cfbot, etc? |
| Previous Message | Richard Guo | 2023-08-11 02:31:34 | Simplify create_merge_append_path a bit for clarity |