Re: row filtering for logical replication

From: Amit Kapila <amit(dot)kapila16(at)gmail(dot)com>
To: "houzj(dot)fnst(at)fujitsu(dot)com" <houzj(dot)fnst(at)fujitsu(dot)com>
Cc: Peter Smith <smithpb2250(at)gmail(dot)com>, Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org>, Euler Taveira <euler(at)eulerto(dot)com>, Greg Nancarrow <gregn4422(at)gmail(dot)com>, vignesh C <vignesh21(at)gmail(dot)com>, Ajin Cherian <itsajin(at)gmail(dot)com>, "tanghy(dot)fnst(at)fujitsu(dot)com" <tanghy(dot)fnst(at)fujitsu(dot)com>, Dilip Kumar <dilipbalaut(at)gmail(dot)com>, Rahila Syed <rahilasyed90(at)gmail(dot)com>, Peter Eisentraut <peter(dot)eisentraut(at)enterprisedb(dot)com>, Önder Kalacı <onderkalaci(at)gmail(dot)com>, japin <japinli(at)hotmail(dot)com>, Michael Paquier <michael(at)paquier(dot)xyz>, David Steele <david(at)pgmasters(dot)net>, Craig Ringer <craig(at)2ndquadrant(dot)com>, Amit Langote <amitlangote09(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: row filtering for logical replication
Date: 2022-02-15 10:01:13
Message-ID: CAA4eK1LHQ+hoj_A5TPuhEfK90aK1psacVZ9TRdUpsyRWnKPH7A@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Tue, Feb 15, 2022 at 7:57 AM houzj(dot)fnst(at)fujitsu(dot)com
<houzj(dot)fnst(at)fujitsu(dot)com> wrote:
>
> On Monday, February 14, 2022 8:56 PM houzj(dot)fnst(at)fujitsu(dot)com wrote:
> >
> > On Friday, February 11, 2022 5:02 PM houzj(dot)fnst(at)fujitsu(dot)com wrote:
> > >
> > > Attach the v81 patch which addressed above comments.
> >
> > Attach the v82 patch which was rebased based on recent commit.
> >
> > The new version patch also includes the following changes:
> >
> > - disallow specifying row filter for partitioned table if pubviaroot is false.
> > Since only the partition's row filter would be used if pubviaroot is false,
> > so disallow this case to avoid confusion.

I have slightly modified the error messages and checks for this
change. Additionally, I changed a few comments and adapt the test case
for changes in commit 549ec201d6132b7c7ee11ee90a4e02119259ba5b.

The patch looks good to me. I am planning to commit this later this
week (on Friday) unless there are any major comments.

--
With Regards,
Amit Kapila.

Attachment Content-Type Size
v84-0001-Allow-specifying-row-filters-for-logical-replica.patch application/octet-stream 177.6 KB

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Greg Nancarrow 2022-02-15 10:07:15 Re: On login trigger: take three
Previous Message Wenjing Zeng 2022-02-15 09:03:56 Re: [Proposal] Global temporary tables