Re: row filtering for logical replication

On Tue, Feb 15, 2022 at 3:31 PM Amit Kapila <amit(dot)kapila16(at)gmail(dot)com> wrote:
>
> On Tue, Feb 15, 2022 at 7:57 AM houzj(dot)fnst(at)fujitsu(dot)com
> <houzj(dot)fnst(at)fujitsu(dot)com> wrote:
>
> I have slightly modified the error messages and checks for this
> change. Additionally, I changed a few comments and adapt the test case
> for changes in commit 549ec201d6132b7c7ee11ee90a4e02119259ba5b.
>
>

Attached is the version with a few changes: (a) make the WHERE
expression in 'docs'/'code comments' consistent; (b) changed one of
the error messages a bit, (c) use ObjectIdGetDatum instead of oid in
one of the SearchSysCacheCopy1 calls.

> The patch looks good to me. I am planning to commit this later this
> week (on Friday) unless there are any major comments.
>

As there is a new version, I would like to wait for a few more days
before committing. I am planning to commit this early next week (by
Tuesday) unless others or I see any more things that can be improved.

I would once like to mention the replica identity handling of the
patch. Right now, (on HEAD) we are not checking the replica identity
combination at DDL time, they are checked at execution time in
CheckCmdReplicaIdentity(). This patch follows the same scheme and
gives an error at the time of update/delete if the table publishes
update/delete and the publication(s) has a row filter that contains
non-replica-identity columns. We had earlier thought of handling it at
DDL time but that won't follow the existing scheme and has a lot of
complications as explained in emails [1][2]. Do let me know if you see
any problem here?

[1] - https://www.postgresql.org/message-id/CAA4eK1+m45Xyzx7AUY9TyFnB6CZ7_+_uooPb7WHSpp7UE=YmKg@mail.gmail.com
[2] - https://www.postgresql.org/message-id/CAA4eK1+1DMkCip9SB3B0_u0Q6fGf-D3vgqQodkLfur0qkL482g@mail.gmail.com

--
With Regards,
Amit Kapila.