Re: Single transaction in the tablesync worker?

From: Amit Kapila <amit(dot)kapila16(at)gmail(dot)com>
To: Peter Smith <smithpb2250(at)gmail(dot)com>
Cc: PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: Single transaction in the tablesync worker?
Date: 2021-01-25 03:54:25
Message-ID: CAA4eK1L1j5sfBgHb0-H-+2quBstsA3hMcDfP-4vLuU-UF43nXQ@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Mon, Jan 25, 2021 at 8:23 AM Peter Smith <smithpb2250(at)gmail(dot)com> wrote:
>
> On Sat, Jan 23, 2021 at 11:26 PM Amit Kapila <amit(dot)kapila16(at)gmail(dot)com> wrote:
> >
> > 2.
> > @@ -98,11 +102,16 @@
> > #include "miscadmin.h"
> > #include "parser/parse_relation.h"
> > #include "pgstat.h"
> > +#include "postmaster/interrupt.h"
> > #include "replication/logicallauncher.h"
> > #include "replication/logicalrelation.h"
> > +#include "replication/logicalworker.h"
> > #include "replication/walreceiver.h"
> > #include "replication/worker_internal.h"
> > +#include "replication/slot.h"
> >
> > I don't think the above includes are required. They seem to the
> > remnant of the previous approach.
> >
>
> OK. Fixed in the latest patch [v19].
>

You seem to forgot removing #include "replication/slot.h". Check, if
it is not required then remove that as well.

--
With Regards,
Amit Kapila.

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Tom Lane 2021-01-25 04:06:18 Re: PG vs LLVM 12 on seawasp, next round
Previous Message Masahiro Ikeda 2021-01-25 03:53:05 RE: About to add WAL write/fsync statistics to pg_stat_wal view