Re: parallel vacuum - few questions on docs, comments and code

From: Amit Kapila <amit(dot)kapila16(at)gmail(dot)com>
To: Justin Pryzby <pryzby(at)telsasoft(dot)com>
Cc: Bharath Rupireddy <bharath(dot)rupireddyforpostgres(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: parallel vacuum - few questions on docs, comments and code
Date: 2021-05-12 04:17:58
Message-ID: CAA4eK1KXCdL+3fkHqnaK++s4Kkgr+2gVZ3k5v1FHmJNpGX6h-Q@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Tue, May 11, 2021 at 6:31 PM Justin Pryzby <pryzby(at)telsasoft(dot)com> wrote:
>
> On Tue, May 11, 2021 at 05:37:50PM +0530, Bharath Rupireddy wrote:
> > 3) Should the Assert(nindexes > 0); in begin_parallel_vacuum just be
> > Assert(nindexes > 1); as this function is entered only when indexes
> > are > 1?
>
> I think you're right, at least with the current implementation that
> parallelization is done across indexes. Same in parallel_vacuum_main.
>

Yeah, as code stands both of you are right. However, it can be helpful
to test parallelism even with one index say if we implement something
like force_parallel_mode = regress or parallel_leader_participation =
off.

--
With Regards,
Amit Kapila.

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message vignesh C 2021-05-12 04:19:34 Re: Replication slot stats misgivings
Previous Message Pavel Stehule 2021-05-12 04:17:03 Re: Schema variables - new implementation for Postgres 15