| From: | Amit Kapila <amit(dot)kapila16(at)gmail(dot)com> |
|---|---|
| To: | shveta malik <shveta(dot)malik(at)gmail(dot)com> |
| Cc: | "Zhijie Hou (Fujitsu)" <houzj(dot)fnst(at)fujitsu(dot)com>, Masahiko Sawada <sawada(dot)mshk(at)gmail(dot)com>, Nisha Moond <nisha(dot)moond412(at)gmail(dot)com>, "Hayato Kuroda (Fujitsu)" <kuroda(dot)hayato(at)fujitsu(dot)com>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>, vignesh C <vignesh21(at)gmail(dot)com>, Dilip Kumar <dilipbalaut(at)gmail(dot)com> |
| Subject: | Re: Conflict detection for update_deleted in logical replication |
| Date: | 2025-09-16 08:34:34 |
| Message-ID: | CAA4eK1KV4bX67qdh0jre6uokxAsZ58fan4d3NPCR+ViSgO-FBw@mail.gmail.com |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Tue, Sep 16, 2025 at 11:13 AM shveta malik <shveta(dot)malik(at)gmail(dot)com> wrote:
>
> >
> > I updated the patch to fix this as well.
> >
>
> Thank You for the patch. Fix looks good.
>
> Shall we update the comment:
> +# Drop the physical slot and reset the synchronized_standby_slots setting. We
> +# change this after setting max_retention_duration to 0, ensuring the apply
> +# worker does not resume prematurely without noticing the updated
> +# max_retention_duration value.
>
> to:
> Drop the physical slot and reset the synchronized_standby_slots
> setting. This adjustment is made after setting max_retention_duration
> to 0, ensuring consistent results in the test case as the resumption
> becomes possible immediately after resetting
> synchronized_standby_slots, due to the smaller max_retention_duration
> value of 1ms previously.
>
Thanks, I have modified the patch based on what you suggested and pushed.
--
With Regards,
Amit Kapila.
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Peter Smith | 2025-09-16 08:47:14 | Re: Add support for specifying tables in pg_createsubscriber. |
| Previous Message | Jakub Wartak | 2025-09-16 08:34:03 | Re: Suggestion to add --continue-client-on-abort option to pgbench |