| From: | Amit Kapila <amit(dot)kapila16(at)gmail(dot)com> |
|---|---|
| To: | Dilip Kumar <dilipbalaut(at)gmail(dot)com> |
| Cc: | "houzj(dot)fnst(at)fujitsu(dot)com" <houzj(dot)fnst(at)fujitsu(dot)com>, Andres Freund <andres(at)anarazel(dot)de>, Thomas Munro <thomas(dot)munro(at)gmail(dot)com>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>, Masahiko Sawada <sawada(dot)mshk(at)gmail(dot)com>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
| Subject: | Re: Separate out FileSet from SharedFileSet (was Re: pgsql: pgstat: Bring up pgstat in BaseInit() to fix uninitialized use o) |
| Date: | 2021-08-25 12:19:20 |
| Message-ID: | CAA4eK1KLu4PeHXH4Ud6CL5KVm61pQiLH+4CLPJUrDOU3HuCTwQ@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-committers pgsql-hackers |
On Tue, Aug 24, 2021 at 3:55 PM Dilip Kumar <dilipbalaut(at)gmail(dot)com> wrote:
>
> On Tue, Aug 24, 2021 at 12:26 PM Amit Kapila <amit(dot)kapila16(at)gmail(dot)com> wrote:
>
The first patch looks good to me. I have made minor changes to the
attached patch. The changes include: fixing compilation warning, made
some comment changes, ran pgindent, and few other cosmetic changes. If
you are fine with the attached, then kindly rebase the second patch
atop it.
--
With Regards,
Amit Kapila.
| Attachment | Content-Type | Size |
|---|---|---|
| v5-0001-Refactor-sharedfileset.c-to-separate-out-fileset-.patch | application/octet-stream | 42.1 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Robert Haas | 2021-08-25 13:31:18 | pgsql: Fix broken snapshot handling in parallel workers. |
| Previous Message | Daniel Gustafsson | 2021-08-25 12:02:05 | Re: pgsql: psql: Add test for query canceling |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Amit Kapila | 2021-08-25 12:23:31 | Re: Failure of subscription tests with topminnow |
| Previous Message | Robert Haas | 2021-08-25 12:03:24 | Re: replay of CREATE TABLESPACE eats data at wal_level=minimal |