| From: | Amit Kapila <amit(dot)kapila16(at)gmail(dot)com> |
|---|---|
| To: | Masahiko Sawada <masahiko(dot)sawada(at)2ndquadrant(dot)com> |
| Cc: | Mahendra Singh Thalor <mahi6run(at)gmail(dot)com>, Masahiko Sawada <sawada(dot)mshk(at)gmail(dot)com>, Robert Haas <robertmhaas(at)gmail(dot)com>, Tomas Vondra <tomas(dot)vondra(at)2ndquadrant(dot)com>, Sergei Kornilov <sk(at)zsrv(dot)org>, Dilip Kumar <dilipbalaut(at)gmail(dot)com>, Kyotaro HORIGUCHI <horiguchi(dot)kyotaro(at)lab(dot)ntt(dot)co(dot)jp>, Haribabu Kommi <kommi(dot)haribabu(at)gmail(dot)com>, Michael Paquier <michael(dot)paquier(at)gmail(dot)com>, Amit Langote <langote_amit_f8(at)lab(dot)ntt(dot)co(dot)jp>, David Steele <david(at)pgmasters(dot)net>, Claudio Freire <klaussfreire(at)gmail(dot)com>, Simon Riggs <simon(at)2ndquadrant(dot)com>, Pavan Deolasee <pavan(dot)deolasee(at)gmail(dot)com>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: [HACKERS] Block level parallel vacuum |
| Date: | 2020-01-09 10:33:30 |
| Message-ID: | CAA4eK1JOmP5c1Cc+BKF+rv60Z21PjjD_FhWO5=Mce9t4u9uRSw@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Thu, Jan 9, 2020 at 10:41 AM Masahiko Sawada
<masahiko(dot)sawada(at)2ndquadrant(dot)com> wrote:
>
> On Wed, 8 Jan 2020 at 22:16, Amit Kapila <amit(dot)kapila16(at)gmail(dot)com> wrote:
> >
> >
> > What do you think of the attached? Sawada-san, kindly verify the
> > changes and let me know your opinion.
>
> I agreed to not include both the FAST option patch and
> DISABLE_LEADER_PARTICIPATION patch at this stage. It's better to focus
> on the main part and we can discuss and add them later if want.
>
> I've looked at the latest version patch you shared. Overall it looks
> good and works fine. I have a few small comments:
>
I have addressed all your comments and slightly change nearby comments
and ran pgindent. I think we can commit the first two preparatory
patches now unless you or someone else has any more comments on those.
Tomas, most of your comments were in the main patch
(v43-0002-Allow-vacuum-command-to-process-indexes-in-parallel) which
are now addressed and we have provided the reasons for the proposed
API changes in patch
v43-0001-Introduce-IndexAM-fields-for-parallel-vacuum. Do you have
any concerns if we commit the API patch and then in a few days time
(after another pass or two) commit the main patch?
--
With Regards,
Amit Kapila.
EnterpriseDB: http://www.enterprisedb.com
| Attachment | Content-Type | Size |
|---|---|---|
| v4-0001-Delete-empty-pages-in-each-pass-during-GIST-VACUUM.patch | application/octet-stream | 15.7 KB |
| v43-0001-Introduce-IndexAM-fields-for-parallel-vacuum.patch | application/octet-stream | 10.3 KB |
| v43-0002-Allow-vacuum-command-to-process-indexes-in-parallel.patch | application/octet-stream | 79.3 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Christoph Berg | 2020-01-09 10:45:11 | Re: Allow 'sslkey' and 'sslcert' in postgres_fdw user mappings |
| Previous Message | Christoph Berg | 2020-01-09 10:30:14 | Re: Allow 'sslkey' and 'sslcert' in postgres_fdw user mappings |