| From: | Amit Kapila <amit(dot)kapila16(at)gmail(dot)com> |
|---|---|
| To: | Önder Kalacı <onderkalaci(at)gmail(dot)com> |
| Cc: | "shiy(dot)fnst(at)fujitsu(dot)com" <shiy(dot)fnst(at)fujitsu(dot)com>, Andres Freund <andres(at)anarazel(dot)de>, Marco Slot <marco(dot)slot(at)gmail(dot)com>, Peter Smith <smithpb2250(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, "wangw(dot)fnst(at)fujitsu(dot)com" <wangw(dot)fnst(at)fujitsu(dot)com> |
| Subject: | Re: [PATCH] Use indexes on the subscriber when REPLICA IDENTITY is full on the publisher |
| Date: | 2023-03-08 11:42:06 |
| Message-ID: | CAA4eK1+oM_v-b_WDHZmqCyVHU2oD4j3vF9YcH9xVHj=zAfy4og@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Wed, Mar 8, 2023 at 4:51 PM Önder Kalacı <onderkalaci(at)gmail(dot)com> wrote:
>
>
>>
>> I just share this case and then we
>> can discuss should we pick the index which only contain the extra columns on the
>> subscriber.
>>
>
> I think its performance implications come down to the discussion on [1]. Overall, I prefer
> avoiding adding any additional complexity in the code for some edge cases. The code
> can handle this sub-optimal user pattern, with a sub-optimal performance.
>
It is fine to leave this and Hou-San's case if they make the patch
complex. However, it may be better to give it a try and see if this or
other regression/optimization can be avoided without adding much
complexity to the patch. You can prepare a top-up patch and then we
can discuss it.
--
With Regards,
Amit Kapila.
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Drouvot, Bertrand | 2023-03-08 11:55:34 | Re: Track IO times in pg_stat_io |
| Previous Message | Önder Kalacı | 2023-03-08 11:21:12 | Re: [PATCH] Use indexes on the subscriber when REPLICA IDENTITY is full on the publisher |