Re: segfault in hot standby for hash indexes

From: Amit Kapila <amit(dot)kapila16(at)gmail(dot)com>
To: Jeff Janes <jeff(dot)janes(at)gmail(dot)com>
Cc: pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: segfault in hot standby for hash indexes
Date: 2017-03-21 08:24:57
Message-ID: CAA4eK1+YUedok0+meynnf8K3fqFsfdMpEFz1JiKLyyNv46hjaA@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Tue, Mar 21, 2017 at 1:28 PM, Jeff Janes <jeff(dot)janes(at)gmail(dot)com> wrote:
> Against an unmodified HEAD (17fa3e8), I got a segfault in the hot standby.
>

I think I see the problem in hash_xlog_vacuum_get_latestRemovedXid().
It seems to me that we are using different block_id for registering
the deleted items in xlog XLOG_HASH_VACUUM_ONE_PAGE and then using
different block_id for fetching those items in
hash_xlog_vacuum_get_latestRemovedXid(). So probably matching those
will fix this issue (instead of fetching block number and items from
block_id 1, we should use block_id 0).

--
With Regards,
Amit Kapila.
EnterpriseDB: http://www.enterprisedb.com

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Hari Krishnan 2017-03-21 08:36:13 Implementing delete in columnar store fdw
Previous Message Antonin Houska 2017-03-21 08:17:21 Re: Partition-wise aggregation/grouping