Re: Command Triggers, patch v11

From: Thom Brown <thom(at)linux(dot)com>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: Dimitri Fontaine <dimitri(at)2ndquadrant(dot)fr>, PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Command Triggers, patch v11
Date: 2012-02-28 15:14:29
Message-ID: CAA-aLv43Ka8P0oF5-+L3qkHnd6cFgMPNL+Z4ag-Va2+T6QiDEQ@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On 28 February 2012 15:03, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
> Thom Brown <thom(at)linux(dot)com> writes:
>> Well the problem is that you can add commands to a trigger en masse,
>> but you can only remove them one at a time.  Couldn't we at least
>> allow the removal of multiple commands at the same time?  The docs you
>> wrote suggest you can do this, but you can't.
>
> This seems over-complicated.  Triggers on tables do not have alterable
> properties, why should command triggers?  I vote for
>
>        CREATE COMMAND TRIGGER name ... properties ...;
>
>        DROP COMMAND TRIGGER name;
>
> full stop.  If you want to run the same trigger function on some more
> commands, add another trigger name.

This would make more sense, particularly since dropping a command
trigger, as it stands, doesn't necessarily drop the trigger.

--
Thom

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Robert Haas 2012-02-28 15:27:36 Re: pgsql_fdw, FDW for PostgreSQL server
Previous Message Tom Lane 2012-02-28 15:14:19 Re: FDW system columns