| From: | "Imseih (AWS), Sami" <simseih(at)amazon(dot)com> |
|---|---|
| To: | Robert Haas <robertmhaas(at)gmail(dot)com>, Masahiko Sawada <sawada(dot)mshk(at)gmail(dot)com>, "Bossart, Nathan" <bossartn(at)amazon(dot)com>, "Andres Freund" <andres(at)anarazel(dot)de> |
| Cc: | Peter Geoghegan <pg(at)bowt(dot)ie>, Justin Pryzby <pryzby(at)telsasoft(dot)com>, "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Add index scan progress to pg_stat_progress_vacuum |
| Date: | 2022-04-14 01:32:54 |
| Message-ID: | CA069E2B-5A89-43D9-BD5C-B033B7EC32D0@amazon.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Taking the above feedback, I modified the patches
and I believe this approach should be acceptable.
For now, I also reduced the scope to only exposing
Indexes_total and indexes_completed in
pg_stat_progress_vacuum. I will create a new CF entry
for the new view pg_stat_progress_vacuum_index.
V10-0001: This patch adds a callback to ParallelContext
that could be called by the leader in vacuumparallel.c
and more importantly while the leader is waiting
for the parallel workers to complete inside.
This ensures that the leader is continuously polling and
reporting completed indexes for the life of the PARALLEL
VACUUM. This covers cases where the leader completes
vacuuming before the workers complete.
V10-0002: This implements the indexes_total and
indexes_completed columns in pg_stat_progress_vacuum.
This work is now tracked in the next commitfest:
https://commitfest.postgresql.org/38/3617/
Regards,
Sami Imseih
Amazon Web Services
| Attachment | Content-Type | Size |
|---|---|---|
| v10-0001-Add-progress-reporting-callback-to-ParallelConte.patch | application/octet-stream | 2.3 KB |
| v10-0002-Show-progress-for-index-vacuums.patch | application/octet-stream | 9.6 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Andres Freund | 2022-04-14 01:51:12 | Re: Intermittent buildfarm failures on wrasse |
| Previous Message | Tom Lane | 2022-04-14 01:23:12 | Re: Intermittent buildfarm failures on wrasse |