| From: | Paul A Jungwirth <pj(at)illuminatedcomputing(dot)com> |
|---|---|
| To: | Haibo Yan <tristan(dot)yim(at)gmail(dot)com> |
| Cc: | Andrew Krylosov <krylosov(dot)andrew(at)gmail(dot)com>, jian he <jian(dot)universality(at)gmail(dot)com>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: addFkRecurseReferencing use unassigned fkconstraint->fk_with_period value |
| Date: | 2026-10-09 05:21:49 |
| Message-ID: | CA+renyXVqed2GBrfKQuZd8sgprNE1WnVb2TFHaEFk1YM6ab=_g@mail.gmail.com |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Mon, Sep 28, 2026 at 11:18 PM Haibo Yan <tristan(dot)yim(at)gmail(dot)com> wrote:
>
changed the wording to "with pre-existing
> rows" and moved the NOT VALID / NOT ENFORCED tests after the
> pg_get_constraintdef checks.
>
> There are no code changes from v1.
This looks good to me too. Andres reported the VALIDATE CONSTRAINT
case in [0], but it's nice to have fixes to all three cases in one
place.
If you want, here is a v3 with a less verbose commit message. Also I
added the note suggested by Andrew, which seems worth including in
release notes.
Yours,
--
Paul ~{:-)
pj(at)illuminatedcomputing(dot)com
| Attachment | Content-Type | Size |
|---|---|---|
| v3-0001-Fix-loss-of-PERIOD-semantics-when-validating-temp.patch | application/octet-stream | 14.4 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Michael Paquier | 2026-10-09 05:37:24 | Re: Use WALReadFromBuffers in more places |
| Previous Message | shihao zhong | 2026-10-09 05:01:39 | Re: pg_resetwal: add --cluster-state option |