| From: | Paul A Jungwirth <pj(at)illuminatedcomputing(dot)com> |
|---|---|
| To: | Zsolt Parragi <zsolt(dot)parragi(at)percona(dot)com> |
| Cc: | Sergei Patiakin <sergei(dot)patiakin(at)enterprisedb(dot)com>, pgsql-hackers(at)lists(dot)postgresql(dot)org, Peter Eisentraut <peter(at)eisentraut(dot)org> |
| Subject: | Re: Inconsistent trigger behavior between two temporal leftovers |
| Date: | 2026-05-05 21:48:10 |
| Message-ID: | CA+renyWRW2XUoqXL7-WOEeTh2gW4dsTQMACR1fGNRFJTmsggBw@mail.gmail.com |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Tue, May 5, 2026 at 2:16 PM Zsolt Parragi <zsolt(dot)parragi(at)percona(dot)com> wrote:
>
> + /*
> + * Re-copy the original row into leftoverSlot because
> + * ExecInsert may pass leftoverSlot to BEFORE INSERT
> + * triggers, which can modify the slot contents.
> + */
>
> Shouldn't this mention BEFORE ROW INSERT triggers? Everywhere else the
> comments/commit message/test is specific about this.
I agree being specific is helpful. Here is an updated patch.
Yours,
--
Paul ~{:-)
pj(at)illuminatedcomputing(dot)com
| Attachment | Content-Type | Size |
|---|---|---|
| v2-0001-Fix-cross-leftover-pollution-in-FOR-PORTION-OF-in.patch | text/x-patch | 5.0 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Paul A Jungwirth | 2026-05-05 21:50:05 | Re: FOR PORTION OF does not recompute GENERATED STORED columns that depend on the range column |
| Previous Message | Nathan Bossart | 2026-05-05 21:47:07 | Re: pgindent versus struct members and typedefs |