Re: Pluggable Storage - Andres's take

From: Dmitry Dolgov <9erthalion6(at)gmail(dot)com>
To: Andres Freund <andres(at)anarazel(dot)de>
Cc: Haribabu Kommi <kommi(dot)haribabu(at)gmail(dot)com>, Amit Langote <Langote_Amit_f8(at)lab(dot)ntt(dot)co(dot)jp>, Peter Geoghegan <pg(at)bowt(dot)ie>, Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>, Alexander Korotkov <a(dot)korotkov(at)postgrespro(dot)ru>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Pluggable Storage - Andres's take
Date: 2019-01-12 12:42:25
Message-ID: CA+q6zcXmZyv+GAHOthCiq_6R1t9SSG19tREbfWNE99O1MSDLig@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox
Thread:
Lists: pgsql-hackers

> On Sat, Jan 12, 2019 at 1:44 AM Andres Freund <andres(at)anarazel(dot)de> wrote:
>
> > + appendPQExpBuffer(cmd, "SET default_table_access_method = %s;", tableam);
>
> This needs escaping, at the very least with "", but better with proper
> routines for dealing with identifiers.

Thanks for noticing, fixed.

> > @@ -5914,7 +5922,7 @@ getTables(Archive *fout, int *numTables)
> > "tc.relfrozenxid AS tfrozenxid, "
> > "tc.relminmxid AS tminmxid, "
> > "c.relpersistence, c.relispopulated, "
> > - "c.relreplident, c.relpages, "
> > + "c.relreplident, c.relpages, am.amname AS amname, "
>
> That AS doesn't do anything, does it?

Rigth, I've renamed it few times and forgot to get rid of it. Removed.

>
> > /* other fields were zeroed above */
> >
> > @@ -9355,7 +9370,7 @@ dumpComment(Archive *fout, const char *type, const char *name,
> > * post-data.
> > */
> > ArchiveEntry(fout, nilCatalogId, createDumpId(),
> > - tag->data, namespace, NULL, owner,
> > + tag->data, namespace, NULL, owner, NULL,
> > "COMMENT", SECTION_NONE,
> > query->data, "", NULL,
> > &(dumpId), 1,
>
> We really ought to move the arguments to a struct, so we don't generate
> quite as much useless diffs whenever we do a change around one of
> these...

That's what I though too. Maybe then I'll suggest a mini-patch to the master to
refactor these arguments out into a separate struct, so we can leverage it here.

Attachment Content-Type Size
pg_dump_access_method_v2.patch application/octet-stream 27.5 KB

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Alexey Bashtanov 2019-01-12 15:00:04 Re: log bind parameter values on error
Previous Message Amit Kapila 2019-01-12 11:32:29 Re: Logical decoding for operations on zheap tables