| From: | Dmitry Dolgov <9erthalion6(at)gmail(dot)com> |
|---|---|
| To: | Arthur Zakirov <a(dot)zakirov(at)postgrespro(dot)ru> |
| Cc: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, David Steele <david(at)pgmasters(dot)net>, peter(dot)eisentraut(at)2ndquadrant(dot)com, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: [PATCH] Generic type subscripting |
| Date: | 2017-04-07 14:49:00 |
| Message-ID: | CA+q6zcX+HBjSp9nX-SFhmAQ5k7waU4yDnbnyvZPJHy+E+8258A@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
> On 1 April 2017 at 21:26, Arthur Zakirov <a(dot)zakirov(at)postgrespro(dot)ru> wrote:
>
> Also I was wondering do we need this code in array_subscript_parse()? I
> haven't understood the purpose of it. If it is necessary then would be
> good to add explain comment.
Well, it's necessary because `array_type` can be modified by
`transformArrayType` and we have to perform coercion again. I'm not sure if
more explanation for that is required, can you suggest something to add
here?
> I don't understand this part of the patch. Why is it necessary to
> execute transformArrayType() second time? It was executed in
> transformContainerSubscripts().
Yes, that's my mistake, I removed one from `parse_node.c`.
Here is a new slightly improved version of the patch.
| Attachment | Content-Type | Size |
|---|---|---|
| generic_type_subscription_v12.patch | text/x-patch | 215.7 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Masahiko Sawada | 2017-04-07 14:56:05 | Re: Transactions involving multiple postgres foreign servers |
| Previous Message | Andrew Dunstan | 2017-04-07 14:03:01 | Re: src/interfaces/libpq shipping nmake-related Makefiles |