Re: [HACKERS] advanced partition matching algorithm for partition-wise join

From: Dmitry Dolgov <9erthalion6(at)gmail(dot)com>
To: Amit Langote <Langote_Amit_f8(at)lab(dot)ntt(dot)co(dot)jp>, Antonin Houska <ah(at)cybertec(dot)at>, Robert Haas <robertmhaas(at)gmail(dot)com>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>
Cc: ashutosh(dot)bapat(dot)oss(at)gmail(dot)com
Subject: Re: [HACKERS] advanced partition matching algorithm for partition-wise join
Date: 2018-11-25 20:04:29
Message-ID: CA+q6zcW_tdoZQUjuV34SkDSQhb8sfbzk6u3L9Qouf7Hdm3pgpg@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox
Thread:
Lists: pgsql-hackers

> On Thu, Oct 25, 2018 at 11:19 PM Dmitry Dolgov <9erthalion6(at)gmail(dot)com> wrote:
>
> Since most of my complaints about the patch were related to code readability,
> I modified it a bit to show more clearly what I have in mind. I haven't changed
> anything about the functionality, just adjusted some parts of it:
>
> * removed some unused arguments (looks like they were added for consistency in
> all higher level branches, but not all of them were actually in use)
>
> * replaced representation for partition mapping (instead of int arrays there is
> a structure, that allows to replace 0/1 with more meaningful from/to)
>
> * tried to make naming a bit more consistent - so, if a function doesn't
> explicitely say anything about outer/inner, we have partmap1/partmap2,
> otherwise outermap/innermap. I don't really like this style with
> partmap1/partmap2 or index1/index2, but it seems consistent with the rest of
> the code in partbounds.c
>
> * removed some state representation flags, e.g. merged - instead, if there is a
> situation when we can't merge, functions will return NULL right away
>
> * removed questionable debugging statement

I've noticed, that this patch set is outdated, so here is the rebased version.

Attachment Content-Type Size
0001-Hash-partition-bound-equality-refactoring-v13.patch application/octet-stream 5.1 KB
0002-Targetlist-of-a-child-join-is-produced-by-translating-v13.patch application/octet-stream 3.5 KB
0003-Partition-wise-join-for-1-1-1-0-0-1-partition-matching-v13.patch application/octet-stream 72.3 KB
0004-Tests-for-0-1-1-1-and-1-0-partition-matching-v13.patch application/octet-stream 220.4 KB

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Thomas Munro 2018-11-25 20:30:49 Re: [HACKERS] [PATCH] Generic type subscripting
Previous Message Stephen Frost 2018-11-25 19:40:32 Re: Updated backup APIs for non-exclusive backups