| From: | Dmitry Dolgov <9erthalion6(at)gmail(dot)com> |
|---|---|
| To: | Vitaly Burovoy <vitaly(dot)burovoy(at)gmail(dot)com> |
| Cc: | David Steele <david(at)pgmasters(dot)net>, Petr Jelinek <petr(at)2ndquadrant(dot)com>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: [PATH] Jsonb, insert a new value into an array at arbitrary position |
| Date: | 2016-03-31 06:51:45 |
| Message-ID: | CA+q6zcW1A2bPsAmzoomHb34OAnVpggggvW9CuPc_kCw1b+LtoQ@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 31 March 2016 at 05:04, Vitaly Burovoy <vitaly(dot)burovoy(at)gmail(dot)com> wrote:
> The documentation changes still has to be fixed.
>
Thanks for help. Looks like I'm not so good at text formulation. Fixed.
> Moreover it seems the logic in the code is correct
No - I see now, that I made the same mistake in two places (e.g. in case of
`setPathArray` a current item was pushed to parse state after
`JB_PATH_INSERT_BEFORE`, not a new one), so they were annihilated. Fixed.
| Attachment | Content-Type | Size |
|---|---|---|
| jsonb_insert_v5.patch | text/x-patch | 18.7 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Etsuro Fujita | 2016-03-31 07:38:11 | Re: Optimization for updating foreign tables in Postgres FDW |
| Previous Message | Tomas Vondra | 2016-03-31 06:42:50 | Re: PATCH: index-only scans with partial indexes |