Re: Flexible permissions for REFRESH MATERIALIZED VIEW

From: Dmitry Dolgov <9erthalion6(at)gmail(dot)com>
To: Robert Haas <robertmhaas(at)gmail(dot)com>
Cc: Greg Stark <stark(at)mit(dot)edu>, Stephen Frost <sfrost(at)snowman(dot)net>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, "David G(dot) Johnston" <david(dot)g(dot)johnston(at)gmail(dot)com>, isaac(dot)morland(at)gmail(dot)com, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Flexible permissions for REFRESH MATERIALIZED VIEW
Date: 2018-11-05 15:19:07
Message-ID: CA+q6zcVNyASx4T9w_GpRHWzUBJNUKmWceX3OYN388raRSqX-sg@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

> On Mon, 21 May 2018 at 15:46, Robert Haas <robertmhaas(at)gmail(dot)com> wrote:
>
> On Sat, May 19, 2018 at 12:59 PM, Greg Stark <stark(at)mit(dot)edu> wrote:
> > On 19 May 2018 at 01:13, Stephen Frost <sfrost(at)snowman(dot)net> wrote:
> >> I'm not entirely sure about the varlena suggestion, seems like that
> >> would change a great deal more code and be slower, though perhaps not
> >> enough to matter; it's not like our aclitem arrays are exactly optimized
> >> for speed today.
> >
> > I don't actually understand the reason y'all are talking about
> > varlena.
>
> Because aclitem's typlen value in pg_type is currently "12".

This patch went through the last two commit fests without any noticeable
activity. As far as I can see, judging from the discussion, there isn't a
single opinion everyone would agree with, except that simply introducing a new
permission is probably not enough and we need to address how to do this
in an extendable way.

> On Sun, 18 Mar 2018 at 22:05, Isaac Morland <isaac(dot)morland(at)gmail(dot)com> wrote:
>
> Right now I'm really looking for whether anybody observes any problems with
> the basic idea. If it's considered to be at least in principle a good idea
> then I'll go and make a more complete patch.

There were at least two options suggested about how to address the questions
from the discussion (widening AclMode and introducing another type similar to
aclitem, but more flexible, to store an "extended" permissions). Maybe the
constructive approach here would be to try them out and propose a draft
implementation for one of them?

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Alvaro Herrera 2018-11-05 15:59:18 Re: pread() and pwrite()
Previous Message Tomas Vondra 2018-11-05 14:51:06 Re: zheap: a new storage format for PostgreSQL