| From: | Dmitry Dolgov <9erthalion6(at)gmail(dot)com> |
|---|---|
| To: | Vitaly Burovoy <vitaly(dot)burovoy(at)gmail(dot)com> |
| Cc: | David Steele <david(at)pgmasters(dot)net>, Petr Jelinek <petr(at)2ndquadrant(dot)com>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: [PATH] Jsonb, insert a new value into an array at arbitrary position |
| Date: | 2016-03-25 17:47:48 |
| Message-ID: | CA+q6zcVDZAJ51POUSTYdX+87hnZ9VFtkkvMRVWc4fOLhJ3pC9g@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Here is a new version of path, I hope I didn't miss anything. Few notes:
> 4.
> or even create a new constant (there can be better name for it):
> #define JB_PATH_CREATE_OR_INSERT (JB_PATH_INSERT_BEFORE |
> JB_PATH_INSERT_AFTER | JB_PATH_CREATE)
Good idea, thanks.
> 5.
> > if (op_type != JB_PATH_DELETE)
Yes, I just missed that in previous patch.
> 7.
> Please, return the "skip" comment.
Well, I'm still not so sure about that, but if you're so confident then ok
=)
| Attachment | Content-Type | Size |
|---|---|---|
| jsonb_insert_v4.patch | text/x-patch | 18.7 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Abhijit Menon-Sen | 2016-03-25 17:57:20 | Re: dealing with extension dependencies that aren't quite 'e' |
| Previous Message | Dilip Kumar | 2016-03-25 17:32:11 | Re: Move PinBuffer and UnpinBuffer to atomics |